wasm32-wasip1-threads: Correct llvm target name by kolayne · Pull Request #157644 · rust-lang/rust

kolayne · 2026-06-09T07:39:42Z

Intends to fix #131007, a problem with cross-compiling Rust+C++ to wasm32-wasip1-threads: clang will be told to compile for --target=wasm32-wasi, which it interprets as wasm32-wasip1, which is not compatible with wasm32-wasip1-threads.

I wonder if there might be any compatibility issue or something depending on the old incorrect name...

rustbot · 2026-06-09T07:39:45Z

These commits modify compiler targets.
(See the Target Tier Policy.)

rustbot · 2026-06-09T07:39:48Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @mu001999 (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

@rustbot author: the review is finished, PR author should check the comments and take action accordingly
@rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 73 candidates
Random selection from 20 candidates

mu001999 · 2026-06-09T07:44:46Z

r? alexcrichton

alexcrichton · 2026-06-09T13:58:42Z

Apologies but I no longer maintain this wasm target, so I'd prefer it if someone else took a look at this.

r? compiler

adwinwhite · 2026-06-15T01:28:31Z

This fix seems correct to me according to the wasi README.
But I'm unfamiliar with the historical context here.

Would love to hear opinions from target maintainers.
@g0djan @abrown @loganek

abrown · 2026-06-17T16:59:06Z

Yeah, it looks right to me as well. Like @alexcrichton, I'm also not actively maintaining this target any more, though, so it might be more official if @loganek chimes in with a +1.

loganek

seems reasonable to me

View changes since this review

@abrown

@abrown has [commented](rust-lang#157644 (comment)) that he is no longer maintaining the target. Update the target maintainers list accordingly.

jieyouxu

Since target maintainer(s) have taken a look,

Thanks
r? me @bors r+ rollup

View changes since this review

rust-bors · 2026-06-18T06:21:03Z

📌 Commit 6a6599c has been approved by jieyouxu

It is now in the queue for this repository.

wasm32-wasip1-threads: Correct llvm target name Intends to fix rust-lang#131007, a problem with cross-compiling Rust+C++ to wasm32-wasip1-threads: clang will be told to compile for `--target=wasm32-wasi`, which it interprets as `wasm32-wasip1`, which is not compatible with `wasm32-wasip1-threads`. I wonder if there might be any compatibility issue or something depending on the old incorrect name...

@abrown

rustc book: Update wasm32-wasip1-threads's maintainers list @abrown has [commented](rust-lang#157644 (comment)) that he is no longer maintaining the target. Update the target maintainers list accordingly. r? abrown

wasm32-wasip1-threads: Correct llvm target name Intends to fix rust-lang#131007, a problem with cross-compiling Rust+C++ to wasm32-wasip1-threads: clang will be told to compile for `--target=wasm32-wasi`, which it interprets as `wasm32-wasip1`, which is not compatible with `wasm32-wasip1-threads`. I wonder if there might be any compatibility issue or something depending on the old incorrect name...

@abrown

rustc book: Update wasm32-wasip1-threads's maintainers list @abrown has [commented](rust-lang#157644 (comment)) that he is no longer maintaining the target. Update the target maintainers list accordingly. r? abrown

@abrown

rustc book: Update wasm32-wasip1-threads's maintainers list @abrown has [commented](rust-lang#157644 (comment)) that he is no longer maintaining the target. Update the target maintainers list accordingly. r? abrown

Rollup of 8 pull requests Successful merges: - #158056 (Put internal lints into a single combined pass) - #151132 (Take care to use MSG_EOR with SOCK_SEQPACKET sockets) - #157644 (wasm32-wasip1-threads: Correct llvm target name) - #157912 (stabilize str_from_utf16_endian) - #158048 (Revert "add regression test for Redundant memory strores with mut parameters in by-value returns") - #158051 (Document `with_added_extension` edge cases) - #158054 (fix unresolved import suggestion before outer attributes) - #158062 (rustc book: Update wasm32-wasip1-threads's maintainers list)

@abrown

Rollup merge of #158062 - kolayne:patch-2, r=jieyouxu rustc book: Update wasm32-wasip1-threads's maintainers list @abrown has [commented](#157644 (comment)) that he is no longer maintaining the target. Update the target maintainers list accordingly. r? abrown

Rollup merge of #157644 - kolayne:patch-1, r=jieyouxu wasm32-wasip1-threads: Correct llvm target name Intends to fix #131007, a problem with cross-compiling Rust+C++ to wasm32-wasip1-threads: clang will be told to compile for `--target=wasm32-wasi`, which it interprets as `wasm32-wasip1`, which is not compatible with `wasm32-wasip1-threads`. I wonder if there might be any compatibility issue or something depending on the old incorrect name...

Add support for the wasm32-wasip1-threads target by bumping the `cc` version. Actual fixes: rust-lang/rust#157644, rust-lang/cc-rs#1763.

wasm32-wasip1-threads: Correct llvm target name

6a6599c

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 9, 2026

rustbot assigned mu001999 Jun 9, 2026

rustbot assigned alexcrichton and unassigned mu001999 Jun 9, 2026

rustbot assigned adwinwhite and unassigned alexcrichton Jun 9, 2026

loganek approved these changes Jun 17, 2026

View reviewed changes

kolayne mentioned this pull request Jun 18, 2026

rustc book: Update wasm32-wasip1-threads's maintainers list #158062

Merged

jieyouxu added the O-wasm Target: WASM (WebAssembly), http://webassembly.org/ label Jun 18, 2026

jieyouxu approved these changes Jun 18, 2026

View reviewed changes

rustbot assigned jieyouxu Jun 18, 2026

rust-bors Bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 18, 2026

rustbot unassigned adwinwhite Jun 18, 2026

rust-bors Bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 18, 2026

JonathanBrouwer mentioned this pull request Jun 18, 2026

Rollup of 4 pull requests #158065

Closed

JonathanBrouwer mentioned this pull request Jun 18, 2026

Rollup of 6 pull requests #158066

Closed

jhpratt mentioned this pull request Jun 18, 2026

Rollup of 8 pull requests #158068

Merged

rust-bors Bot merged commit 732e5f7 into rust-lang:main Jun 18, 2026
12 checks passed

rustbot added this to the 1.98.0 milestone Jun 18, 2026

kolayne deleted the patch-1 branch June 18, 2026 12:16

kolayne restored the patch-1 branch June 18, 2026 12:16

kolayne mentioned this pull request Jun 19, 2026

Update src/target/generated.rs rust-lang/cc-rs#1762

Closed

kolayne added a commit to kolayne/xgrammar-rs that referenced this pull request Jun 20, 2026

Support wasm32-wasip1-threads

2f7e8c5

Add support for the wasm32-wasip1-threads target by bumping the `cc` version. Actual fixes: rust-lang/rust#157644, rust-lang/cc-rs#1763.

kolayne mentioned this pull request Jun 20, 2026

Support wasm32-wasip1-threads trymirai/xgrammar-rs#15

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

wasm32-wasip1-threads: Correct llvm target name#157644

wasm32-wasip1-threads: Correct llvm target name#157644
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
kolayne:patch-1

kolayne commented Jun 9, 2026 •

edited by rustbot

Loading

Uh oh!

rustbot commented Jun 9, 2026

Uh oh!

rustbot commented Jun 9, 2026

Uh oh!

mu001999 commented Jun 9, 2026

Uh oh!

alexcrichton commented Jun 9, 2026

Uh oh!

adwinwhite commented Jun 15, 2026

Uh oh!

abrown commented Jun 17, 2026 •

edited

Loading

Uh oh!

loganek left a comment •

edited by rustbot

Loading

Uh oh!

jieyouxu left a comment •

edited by rustbot

Loading

Uh oh!

rust-bors Bot commented Jun 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Uh oh!

Conversation

kolayne commented Jun 9, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jun 9, 2026

Uh oh!

rustbot commented Jun 9, 2026

Uh oh!

mu001999 commented Jun 9, 2026

Uh oh!

alexcrichton commented Jun 9, 2026

Uh oh!

adwinwhite commented Jun 15, 2026

Uh oh!

abrown commented Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

loganek left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jieyouxu left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-bors Bot commented Jun 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

kolayne commented Jun 9, 2026 •

edited by rustbot

Loading

abrown commented Jun 17, 2026 •

edited

Loading

loganek left a comment •

edited by rustbot

Loading

jieyouxu left a comment •

edited by rustbot

Loading